Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --latest-local to the baas test server CLI #6673

Merged
merged 1 commit into from
May 22, 2024

Conversation

kraenhansen
Copy link
Member

What, How & Why?

I got annoyed that our BaaS test server always had to pull the latest baas image and I found it cumbersome to figure out the latest baas image that I had locally. So I turned this into a runtime argument for our BaaS test server command:

npm start --workspace @realm/baas-test-server -- --latest-local

It this works well for people, we might turn this into the default behaviour and instead add a --pull-latest flag.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen self-assigned this May 22, 2024
@cla-bot cla-bot bot added the cla: yes label May 22, 2024
@kraenhansen kraenhansen requested review from kneth and elle-j May 22, 2024 10:06
@kraenhansen kraenhansen added the no-jira-ticket Skip checking the PR title for Jira reference label May 22, 2024
Copy link
Member

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when tests pass :-)

@kraenhansen kraenhansen merged commit 915ede7 into main May 22, 2024
28 of 29 checks passed
@kraenhansen kraenhansen deleted the kh/latest-local-baas-image branch May 22, 2024 14:07
@kraenhansen
Copy link
Member Author

Merging, since the failing test is unrelated to this change 👍

papafe added a commit that referenced this pull request May 23, 2024
* main: (22 commits)
  Prepare for vNext (#6677)
  [12.9.0] Bump version (#6676)
  Fix performance tests (#6665)
  Combined: Support `Mixed` data type with collections (#6613)
  Update expected error messages (#6674)
  Adding --latest-local to the baas test server CLI (#6673)
  Upgrade to Realm Core v14.7.0 (#6663)
  Upgrade @trunk/launcher to v1.3.1 to support Apple's versioning scheme for macOS (#6671)
  Prepare for vNext (#6669)
  [12.8.1] Bump version (#6668)
  Use unreleased core (#6667)
  Fix realm/react changelog (#6661)
  Fix GHA error when publishing package release (#6660)
  Prepend vNext to realm/react changelog.
  [realm-react-0.7.0] Bump version (#6658)
  Update OAuth2Helper to remove accessing the stitch prefix (#6659)
  Fix unresolvable links in API reference docs and remove re-exports (#6646)
  Prepare for vNext (#6645)
  [12.8.0] Bump version (#6643)
  Upgrade to HEAD of Realm Core's master (#6637)
  ...

# Conflicts:
#	CHANGELOG.md
#	integration-tests/tests/src/tests/mixed.ts
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants