Testing tweaks #3517
Merged
Testing tweaks #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsm
reviewed
Jan 15, 2022
book/testing/README.md
Outdated
| the kind you have in OCaml increases that advantage. And while | ||
| type-safe code can easily be wrong, types have a way of increasing the | ||
| rigidity of your code, in a way that makes it snap into place with | ||
| fewer tests than you might expect. All in, tests magnify the power of |
There was a problem hiding this comment.
Do you mean 'types magnify the power of' here?
avsm
reviewed
Jan 15, 2022
book/testing/README.md
Outdated
| ##### `open` and `open!` | ||
|
|
||
| In this example, we use `open!` instead of `open` because we happen | ||
| not to be usinging any values from `Base`, and so the compiler will |
There was a problem hiding this comment.
Suggested change
| not to be usinging any values from `Base`, and so the compiler will | |
| not to be using any values from `Base`, and so the compiler will |
avsm
reviewed
Jan 15, 2022
book/testing/README.md
Outdated
|
|
||
| But because `Base` is effectively our standard library, we want to | ||
| keep it open anyway, since we want any new code we write to find | ||
| `Base`'s libraries, not the ordinary OCaml standard library. The |
There was a problem hiding this comment.
Perhaps refer to Base "modules" here, and not" libraries". We refine that definition later in the platform chapter.
avsm
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.