release: v0.6.0 #52
Merged
release: v0.6.0 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
reviewed
Dec 19, 2019
CHANGES.rst
Outdated
|
|
||
| - Adds fixtures for secrets store. | ||
| - Centralises test requirements. | ||
| - Adds python 3.8 support. |
tiborsimko
reviewed
Dec 19, 2019
setup.py
Outdated
| @@ -50,7 +50,7 @@ | |||
| 'pytest-cov>=1.8.0', | |||
| 'pytest-pep8>=1.0.6', | |||
| 'pytest>=3.8.0,<5.0.0', | |||
| 'reana-commons[kubernetes]>=0.5.0.dev20190416', | |||
| 'reana-commons[kubernetes]>=0.6.0', | |||
There was a problem hiding this comment.
Beware of possible circular dependencies, in the past we used the following to be safe:
$ git show v0.5.0:setup.py | grep reana-
'reana-commons>=0.5.0.dev20190416',
'reana-db>=0.5.0.dev20190416',i.e. the lower dependencies in pytest-reana were liberal (since the package is only used by developers) and the lower dependencies in reana-db and reana-commons were more cleanly delineated:
$ cd ../reana-commons
$ git show v0.5.0:setup.py | grep pytest-reana
'pytest-reana==0.5.0',I.e. we can release pytest-reana first, using YYYMMDD "dev" dependencies, and then reana-commons and reana-db, using pytest-reana 0.6.0.
There was a problem hiding this comment.
Okay, I've updated PR for dev release.
There was a problem hiding this comment.
Need a DEV minimal version such as >=0.6.0.dev20191212 then the package would be installable and Travis CI would pass
roksys
force-pushed
the
release-0.6.0
branch
2 times, most recently
from
42ae4e5
to
5ce8fce
Compare
tiborsimko
force-pushed
the
release-0.6.0
branch
from
5ce8fce
to
e779e4f
Compare
tiborsimko
approved these changes
Dec 19, 2019
|
This should be updated according to our guide. |
tiborsimko
force-pushed
the
release-0.6.0
branch
from
e779e4f
to
79a8b98
Compare
Co-authored-by: Tibor Šimko <tibor.simko@cern.ch> Signed-off-by: Tibor Šimko <tibor.simko@cern.ch>
tiborsimko
force-pushed
the
release-0.6.0
branch
from
79a8b98
to
0bdb36e
Compare
mvidalgarcia
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.