fixtures: create engine inside app fixture #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
pushed a commit
to diegodelemos/reana-job-controller
that referenced
this pull request
Jun 4, 2020
* Fixes single test execution and updates `base_app` fixture according to reanahub/pytest-reana#61.
diegodelemos
pushed a commit
to diegodelemos/reana-job-controller
that referenced
this pull request
Jun 4, 2020
* Fixes single test execution and updates `base_app` fixture according to reanahub/pytest-reana#61.
diegodelemos
pushed a commit
to diegodelemos/reana-job-controller
that referenced
this pull request
Jun 4, 2020
* Updates `base_app` fixture according to reanahub/pytest-reana#61 which fixes a DB initialisation problem.
mvidalgarcia
approved these changes
Jun 4, 2020
tiborsimko
reviewed
Jun 4, 2020
* Previously on single test executions the session would be pointing to the wrong database URI for tests (default), causing the tests to fail.
diegodelemos
force-pushed
the
use-apps-db-uri
branch
from
9aafab2
to
ad3ce93
Compare
diegodelemos
force-pushed
the
use-apps-db-uri
branch
from
ad3ce93
to
a41f27d
Compare
diegodelemos
pushed a commit
to diegodelemos/reana-job-controller
that referenced
this pull request
Jun 5, 2020
* Updates `base_app` fixture according to reanahub/pytest-reana#61 which fixes a DB initialisation problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointing to the wrong database URI for tests (defautl), causing
the tests to fail.