setup: add upper bound to reana-db #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
reviewed
Oct 14, 2020
setup.py
Outdated
| @@ -48,7 +48,7 @@ | |||
| "pytest-cov>=2.8.0,<3.0", | |||
| "pytest>=4.6.0,<5.0.0", | |||
| "reana-commons[kubernetes]>=0.7.0.dev20200203", | |||
There was a problem hiding this comment.
Do we need to pin also r-commons to less than 0.8? Would make sense since this is going to the maint-0.7 branch only... (untested)
There was a problem hiding this comment.
True, didn't notice as I'm working on a r-commons' maint-0.7-based branch directly. I pushed the change, maybe @ParthS007 can test it in his PR?
There was a problem hiding this comment.
Tested it already myself reanahub/reana-workflow-engine-yadage#164 (comment)
mvidalgarcia
force-pushed
the
pin-reana-db
branch
from
1e39c6f
to
ff18b26
Compare
mvidalgarcia
force-pushed
the
pin-reana-db
branch
from
ff18b26
to
2057afe
Compare
This was referenced Oct 14, 2020
tiborsimko
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close reanahub/reana#422