cli: workflow status progress columns #141
Conversation
dinosk
force-pushed
the
progress-columns-prettified-cmd-and-step
branch
from
335e02a
to
1ff9898
Compare
reana_client/cli/workflow.py
Outdated
| @@ -324,62 +364,15 @@ def workflow_status(ctx, workflow, _filter, output_format, | |||
| access_token) | |||
| verbose_headers = ['id', 'user'] | |||
| headers = ['name', 'run_number', 'created', | |||
| 'status', 'progress', 'command'] | |||
| 'status', 'progress'] | |||
There was a problem hiding this comment.
Shall we add progress only if the status response contains progress info? To handle the case in which progress is not still there?
There was a problem hiding this comment.
Note this won't raise an error but show 0/0 as the progress fields are initialized to 0 when a row gets added in Job table. I also think it shouldn't be shown in this case nonetheless.
reana_client/cli/workflow.py
Outdated
| row['status'], | ||
| '{0}/{1}'. | ||
| format( | ||
| row['progress']['succeeded'], |
There was a problem hiding this comment.
Can you reproduce?
$ export REANA_WORKON=$(reana-client create -f reana-yadage.yaml)
$ reana-client status
Workflow status could not be retrieved:
'succeeded'There was a problem hiding this comment.
yes, I'm working on it I forgot to set the label
dinosk
force-pushed
the
progress-columns-prettified-cmd-and-step
branch
from
1ff9898
to
5b8f4f8
Compare
* ADD step column to show current running step in workflow, and show Job.prettified_cmd to command column. Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
dinosk
force-pushed
the
progress-columns-prettified-cmd-and-step
branch
from
5b8f4f8
to
5e64a03
Compare
Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
dinosk
force-pushed
the
progress-columns-prettified-cmd-and-step
branch
from
b5bf961
to
7156be3
Compare
| else: | ||
| return '-/-' | ||
|
|
||
| def _get_data_from_row(row, data, headers): |
There was a problem hiding this comment.
Could we maybe remove data as parameter, and return a new list every time? So down, in workflow_status scope, when we call it we are always in control of what goes inside data making it easier to debug?
and show Job.prettified_cmd in command column.
Connects #125
Signed-off-by: Dinos Kousidis dinos.kousidis@cern.ch