cli: in case of restart returns proper run number

[roksys]

• Addresses refactor: workflow restart/rerun using the same workspace reana-workflow-controller#289

[diegodelemos]

When I test it I get the following:

$ reana-client run 
[INFO] Creating a workflow...
workflow.1.0
[INFO] Uploading files...
File code/helloworld.py was successfully uploaded.
File data/names.txt was successfully uploaded.
[INFO] Starting workflow...
workflow.1.0 is running
$ reana-client create -w workflow  
workflow.2.0
$ reana-client start --restart -w workflow.1
workflow.3.0 is running
$ reana-client list
NAME         RUN_NUMBER   CREATED               STATUS  
workflow     3.0          2020-02-03T14:30:19   finished
workflow     2.0          2020-02-03T14:29:46   created 
workflow     1.0          2020-02-03T14:26:24   finished

However, I would expect:

$ reana-client list
NAME         RUN_NUMBER   CREATED               STATUS  
workflow     1.1          2020-02-03T14:30:19   finished
workflow     2.0          2020-02-03T14:29:46   created 
workflow     1.0          2020-02-03T14:26:24   finished

Or with https://github.com/reanahub/reana-db/pull/57/files#r374135702 I would expect:

$ reana-client list
NAME         RUN_NUMBER   CREATED               STATUS  
workflow     1.1          2020-02-03T14:30:19   finished
workflow     2            2020-02-03T14:29:46   created 
workflow     1            2020-02-03T14:26:24   finished

Another observation is that one can still mess with past workflow run workspaces.

$ reana-client ls -w workflow.1    
NAME                    SIZE   LAST-MODIFIED      
results/greetings.txt   68     2020-02-03T14:30:32
data/names.txt          20     2020-02-03T14:26:25
code/helloworld.py      3253   2020-02-03T14:26:25
$ reana-client ls -w workflow.3
NAME                    SIZE   LAST-MODIFIED      
results/greetings.txt   68     2020-02-03T14:30:32
data/names.txt          20     2020-02-03T14:26:25
code/helloworld.py      3253   2020-02-03T14:26:25
$ reana-client upload README.rst -w workflow.1
File README.rst was successfully uploaded.
$ reana-client ls -w workflow.3
NAME                    SIZE   LAST-MODIFIED      
README.rst              6493   2020-02-03T14:43:47
results/greetings.txt   68     2020-02-03T14:30:32
data/names.txt          20     2020-02-03T14:26:25
code/helloworld.py      3253   2020-02-03T14:26:25

Blocking past restarted workflows workspaces from edition can be done in a different issue.

[diegodelemos]

This commented code can go away now, right?