Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: nicer formatting in diff output #397

Merged
merged 3 commits into from Mar 20, 2020
Merged

cli: nicer formatting in diff output #397

merged 3 commits into from Mar 20, 2020

Conversation

mvidalgarcia
Copy link
Member

closes #389

Before:

image

After:

image

@tiborsimko
Copy link
Member

Looks nice 👍 We can take the occasion and upgrade the headings text a bit:

  • If the diffs are big, then 'In version:' in the middle of a big blob wouldn't be so noticeable/understandable. I'd go for non-nested headings like this:
==> Differences in workflow inputs
==> Differences in workflow specification
==> Differences in workflow outputs
==> Differences in workflow workspace

@mvidalgarcia
cli: fix workspace diff output
cf1d9e8 
When there're no differences between the workspaces, a serialized
empty string is sent (`json.dumps("")`) causing `'""'` as a result
which evaluates as `True` so in the console we always had the
message "Differences in workspace listings".
@mvidalgarcia mvidalgarcia force-pushed the 389-nicer-formatting branch 13 times, most recently from ded1657 to 593366c Compare March 20, 2020 10:19
@tiborsimko tiborsimko merged commit a54c5f5 into reanahub:master Mar 20, 2020
@mvidalgarcia mvidalgarcia deleted the 389-nicer-formatting branch March 20, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborsimko tiborsimko tiborsimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diff: nicer formatting
2 participants
@mvidalgarcia @tiborsimko