Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(snakemake): allow running Snakemake 7 tests on Python 3.11+ (#700) #700

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

giuseppe-steduto
Copy link
Member

After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435)
there is no need to avoid running Snakemake tests on Python 3.11 and
3.12, as it should be supported.

Closes #655

giuseppe-steduto added a commit to giuseppe-steduto/reana-client that referenced this pull request Jan 26, 2024
…#700)

After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435)
there is no need to avoid running Snakemake tests on Python 3.11 and
3.12, as it should be supported.

Closes reanahub#655
@giuseppe-steduto giuseppe-steduto changed the title test: allow Snakemake tests to run on newer Python versions (#699) test: allow Snakemake tests to run on newer Python versions (#700) Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (875997c) 58.62% compared to head (8ad7ff1) 58.62%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   58.62%   58.62%           
=======================================
  Files          24       24           
  Lines        2393     2393           
=======================================
  Hits         1403     1403           
  Misses        990      990           

giuseppe-steduto added a commit to giuseppe-steduto/reana-client that referenced this pull request Jan 26, 2024
…#700)

After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435)
there is no need to avoid running Snakemake tests on Python 3.11 and
3.12, as it should be supported.

Closes reanahub#655
@mdonadoni
Copy link
Member

mdonadoni commented Feb 13, 2024

Could you bump r-commons version in setup.py, to make the CI pass? This PR also needs to be rebased

giuseppe-steduto added a commit to giuseppe-steduto/reana-client that referenced this pull request Feb 13, 2024
…#700)

After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435)
there is no need to avoid running Snakemake tests on Python 3.11 and
3.12, as it should be supported.

Closes reanahub#655
@giuseppe-steduto giuseppe-steduto marked this pull request as ready for review February 13, 2024 14:50
giuseppe-steduto added a commit to giuseppe-steduto/reana-client that referenced this pull request Feb 21, 2024
…#700)

After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435)
there is no need to avoid running Snakemake tests on Python 3.11 and
3.12, as it should be supported.

Closes reanahub#655
…nahub#700)

After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435)
there is no need to avoid running Snakemake tests on Python 3.11 and
3.12, as it should be supported.

Closes reanahub#655
@tiborsimko tiborsimko changed the title test: allow Snakemake tests to run on newer Python versions (#700) test(snakemake): allow running Snakemake 7 tests on Python 3.11+ (#700) Feb 21, 2024
@tiborsimko tiborsimko merged commit 8ad7ff1 into reanahub:master Feb 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python 3.11: cannot submit snakemake workflows
3 participants