Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): change extra names to comply with PEP 685 (#446) #446

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

mdonadoni
Copy link
Member

Since pip>=23.3.0, non-normalised extra names are ignored, so
snakemake_reports is changed to snakemake-reports. The former name
is kept for backward compatibility with older versions of pip.

Before

$ pip install --upgrade pip
$ pip install '.[snakemake-reports]' | grep WARN
WARNING: reana-commons 0.9.7 does not provide the extra 'snakemake-reports'
$ pip install '.[snakemake_reports]' | grep WARN
WARNING: reana-commons 0.9.7 does not provide the extra 'snakemake-reports'

After

$ pip install --upgrade pip
$ pip install '.[snakemake_reports]' | grep WARN
$ pip install '.[snakemake-reports]' | grep WARN

Since pip>=23.3.0, non-normalised extra names are ignored, so
`snakemake_reports` is changed to `snakemake-reports`. The former name
is kept for backward compatibility with older versions of pip.
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.33%. Comparing base (b4a81d5) to head (904178f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   36.33%   36.33%           
=======================================
  Files          26       26           
  Lines        1577     1577           
=======================================
  Hits          573      573           
  Misses       1004     1004           

mdonadoni added a commit to mdonadoni/reana-commons that referenced this pull request Feb 29, 2024
@tiborsimko tiborsimko merged commit 904178f into reanahub:master Mar 1, 2024
17 checks passed
@mdonadoni mdonadoni deleted the pep-685 branch March 1, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants