Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installation: mock upper bound as pytest-reana #221

Merged
merged 1 commit into from Oct 16, 2020
Merged

installation: mock upper bound as pytest-reana #221

merged 1 commit into from Oct 16, 2020

Conversation

diegodelemos
Copy link
Member

tiborsimko
tiborsimko reviewed Oct 15, 2020
View reviewed changes
setup.py
@@ -45,7 +45,7 @@
"fs>=2.0",
"jsonschema[format]>=3.0.1",
"kombu>=4.6,<4.7",
"mock>=3.0",
"mock>=3.0,<4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for master or could it rather be for maint-0.7 as well? Thinking about a situation where we shall have to work in four months on some 0.7.x bugfix.... It could be handy to merge to the lowest branch where the fix applies to and propagate upwards only afterwards?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense, I am changing the branch target :)

@diegodelemos diegodelemos changed the base branch from master to maint-0.7 October 15, 2020 15:09
@tiborsimko tiborsimko merged commit 578d95e into reanahub:maint-0.7 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborsimko tiborsimko tiborsimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup: mock incompatible versions
2 participants
@diegodelemos @tiborsimko