k8s: centralise Kubernetes client #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
tiborsimko
reviewed
Dec 12, 2018
setup.py
Outdated
| @@ -56,6 +56,8 @@ | |||
| 'click>=7.0,<8.0', | |||
| 'jsonschema[format]>=2.6.0,<2.7', | |||
| 'kombu>=4.2.0,<5.0', | |||
| 'kubernetes>=6.0.0', | |||
There was a problem hiding this comment.
Since reana-client also depends on reana-commons, this would bring K8s to the user space world as well...
What about having an option pip install reana-commons[kubernetes] so that the usual reana-client world wouldn't need this and only reana-cluster world would?
* Since R-W-Controller connects now to Kubernetes as well we centralise the initialisation in commons.
diegodelemos
force-pushed
the
r-w-c-158-start-rwe-with-k8s
branch
from
d32eedf
to
06a0420
Compare
okraskaj
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
centralise the initialisation in commons.
Connects reanahub/reana-workflow-controller#158.