consumer: workflow-submission queue #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
* Adds workflow-submission queue to default queues. Refactors configuration to allow for multiple default queues, linked with their parameters. Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
dinosk
force-pushed
the
119-workflow-submission-queue
branch
from
1d55fb7
to
5400f12
Compare
dinosk
force-pushed
the
119-workflow-submission-queue
branch
4 times, most recently
from
d774212
to
7dafafe
Compare
* Adds BasePublisher class. Splits the common part of WorkflowStatusPublisher to a base class. * Adds WorkflowSubmissionPublisher to be used for enqueueing to the workflow submission queue. * Adds sample reana_ready task to check for system availability to start new workflow executions. Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
dinosk
force-pushed
the
119-workflow-submission-queue
branch
5 times, most recently
from
80b3cba
to
5c07f20
Compare
Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
dinosk
force-pushed
the
119-workflow-submission-queue
branch
11 times, most recently
from
176324b
to
b3b08c6
Compare
dinosk
force-pushed
the
119-workflow-submission-queue
branch
2 times, most recently
from
ed7a4db
to
559f1ab
Compare
dinosk
force-pushed
the
119-workflow-submission-queue
branch
11 times, most recently
from
937307e
to
7408e91
Compare
tiborsimko
reviewed
Jan 15, 2019
| """Minimum allocatable pod capacity in cluster to start new workflows.""" | ||
|
|
||
| K8S_MAXIMUM_CONCURRENT_JOBS = 1 | ||
| """Upper limit on concurrent jobs running in the cluster.""" |
There was a problem hiding this comment.
Please check the BSM example and set the defaults very liberally so that almost any input would be accepted... One workflow can generate many jobs and the system may suffer, but we only need to protect ourselves from people starting ~N workflows at the same time.
Also it would be good if these are easily user-settable, e.g. reana-cluster template variable taking precedence.
There was a problem hiding this comment.
With 10 concurrent jobs the BSM example ran on my machine ok. I agree it should be cluster configuration and not in reana-commons - to be improved.
dinosk
force-pushed
the
119-workflow-submission-queue
branch
2 times, most recently
from
ce23cfa
to
38a4de8
Compare
roksys
approved these changes
Jan 16, 2019
* Adds task calling k8s api to check if there are sufficient allocatable resources available in any nodes of the cluster. * Adds REANA_READY_CONDITIONS list containing functions, that define the conditions required to start workflows that are queued. First 2 conditions are checking the k8s predefined conditions for the node status, and an upper limit for concurrently running jobs. Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
* Adds kwargs to constructors of derived publisher classes. * Adds test for reana_ready() task, asserting that the defined conditions for starting queued workflows in the config are checked properly. Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
dinosk
force-pushed
the
119-workflow-submission-queue
branch
from
a2e90ae
to
e05adab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors configuration to allow for multiple default queues,
linked with their parameters.
Connects reanahub/reana#119
Depends on reanahub/pytest-reana#36
Signed-off-by: Dinos Kousidis dinos.kousidis@cern.ch