Workflow query fix #60
Conversation
* psql allows to pass run number as a string while sqlite not
| @@ -103,7 +103,7 @@ def _get_workflow_with_uuid_or_name(uuid_or_name, user_uuid): | |||
| # `run_number` was specified. | |||
| # Check `run_number` is valid. | |||
| try: | |||
| float(run_number) | |||
| run_number = float(run_number) | |||
There was a problem hiding this comment.
Hmm, looking at instances of float and int casting in the code base, and looking at possible RDBMS differences in handling floats, what about:
-
either forcing the run number to be
floateverywhere on the cluster side (e.g.42.0) and hiding the42.0complexity into42on the reana-client side? -
or using two integer columns, run_number and rerun_number, in the DB model, each properly indexed for speed, and defining proper getter/setter hybrid property for run_number lookups that would look in both columns based on run_number string without any needs for float casting?
It might be more robust that way, i.e. considering run number as a string composed of two integers separated by dot, and not casting anything. Let's muse IRL?
No description provided.