installation: adds autodiscovered packages #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2020 13:39
* Adds missing subpackge `alembic` (and all future subpackages) to the production builds (closes reanahub#77).
diegodelemos
force-pushed
the
77-missing-subpackages
branch
from
26bc9c8
to
002a6f7
Compare
diegodelemos
commented
Aug 7, 2020
| @@ -60,11 +60,12 @@ | |||
| name="reana-db", | |||
| version=version, | |||
| description=__doc__, | |||
| license="MIT", | |||
There was a problem hiding this comment.
@tiborsimko, addressing #77 (comment): When the package license is only present in classifiers pip show doesn't show it. For now the only workaround is to use the license parameter, however, the official docs say that this field should only be used to declare custom licenses. More detailed information pypa/pip#6677
There was a problem hiding this comment.
Hmm, so there is no good solution right now... Anyway, if adding license=MIT does not break anything apparent, only goes a bit against the spirit of official docs, we could perhaps have it everywhere while releasing later alpha versions...
tiborsimko
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alembic(and all future subpackages) tothe production builds (closes installation: missing subpackages in production build #77).