serial: added workflow with step names #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprelipcean
moved this from In progress
to Review in progress
in Physics-Examples-Summer-2019
dprelipcean
force-pushed
the
add_workflow_steps_serial
branch
from
09f19ff
to
a712e72
Compare
tiborsimko
reviewed
Sep 11, 2019
Signed-off-by: Daniel Prelipcean <daniel.prelipcean@cern.ch>
dprelipcean
force-pushed
the
add_workflow_steps_serial
branch
from
a712e72
to
9f7833b
Compare
tiborsimko
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
LGTM
BTW we may need to amend progress counting, if we have nicely named and separated steps like this, it may be more intuitive to count 2/2 (going by steps) instead of currently-counted 3/3 (going by commands). Would also make sense for partial workflow execution. I'll ticketise this for later.
Physics-Examples-Summer-2019
automation
moved this from Review in progress
to Reviewer approved
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Prelipcean daniel.prelipcean@cern.ch