docs: autodoc_mock_imports for gssapi #276
Conversation
ParthS007
requested review from
audrium,
diegodelemos,
mvidalgarcia and
tiborsimko
|
@ParthS007 Can you please rebase all your RTFD build fixing branches against |
|
@tiborsimko I have updated the base branch and rebased my current branch. Can you please check if it's fine and let me know if any other changes are required. 👍 |
| @@ -72,6 +71,8 @@ def initialize_krb5_token(workflow_uuid): | |||
| class SSHClient: | |||
| """SSH Client.""" | |||
|
|
|||
| import paramiko | |||
There was a problem hiding this comment.
If we import paramiko in this class, which is a good thing to do, we have to amend all paramiko-related commands to use self.paramiko as the package name, for example:
diff --git a/reana_job_controller/utils.py b/reana_job_controller/utils.py
index 9176495..418ba7a 100644
--- a/reana_job_controller/utils.py
+++ b/reana_job_controller/utils.py
@@ -81,8 +81,8 @@ class SSHClient:
def establish_connection(self):
"""Establish the connection."""
- self.ssh_client = paramiko.SSHClient()
- self.ssh_client.set_missing_host_key_policy(paramiko.AutoAddPolicy())
+ self.ssh_client = self.paramiko.SSHClient()
+ self.ssh_client.set_missing_host_key_policy(self.paramiko.AutoAddPolicy())
self.ssh_client.connect(hostname=self.hostname, port=self.port, gss_auth=True)
def exec_command(self, command):
requirements.in
Outdated
| @@ -0,0 +1,7 @@ | |||
| # This file is part of REANA. | |||
| # Copyright (C) 2017, 2018 CERN. | |||
There was a problem hiding this comment.
2020
(we did not have this file in 2017, 2018)
There was a problem hiding this comment.
You edited the wrong file, the 2020 should be in the new requirements.in file, not in the old MANIFEST.in ...
Adds mocking of 'gssapi' and 'paramiko[gssapi]' that cannot be installed on ReadTheDocs builders. This fixes the ReadTheDocs building problem. closes #274
closes #274
Adds mocking of
gssapithat cannot be installed on ReadTheDocsbuilders.
This fixes the ReadTheDocs building problem.