ci(commitlint): check for the presence of concrete PR number #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
added a commit
to tiborsimko/reana-message-broker
that referenced
this pull request
Jan 25, 2024
Return properly the exit code status of shellcheck command when looping through shell script files.
tiborsimko
added a commit
to tiborsimko/reana-message-broker
that referenced
this pull request
Jan 25, 2024
…b#64) Enrich commitlint checker in order to check the precise PR number in the commit log headline.
tiborsimko
force-pushed
the
ci-commitlint-shellcheck
branch
from
bde87f0
to
16b7431
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 7 7
=========================================
Hits 7 7 |
mdonadoni
approved these changes
Jan 25, 2024
|
Note that shellcheck fails validating one of the shell scripts we have |
Return properly the exit code status of shellcheck command when looping through shell script files.
…b#64) Enrich commitlint checker in order to check the precise PR number in the commit log headline.
tiborsimko
force-pushed
the
ci-commitlint-shellcheck
branch
from
16b7431
to
8283064
Compare
Fixed by switching shell explicitly to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci(commitlint): check for the presence of concrete PR number
Enrich commitlint checker in order to check the precise PR number in the
commit log headline.
ci(shellcheck): fix exit code propagation
Return properly the exit code status of shellcheck command when looping
through shell script files.