Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile #85

Closed
tiborsimko opened this issue Aug 28, 2018 · 0 comments · Fixed by #87
Closed

Dockerfile #85

tiborsimko opened this issue Aug 28, 2018 · 0 comments · Fixed by #87
Assignees
@tiborsimko
Projects
v0.3.0
Milestone
v0.3.0

Comments

@tiborsimko
Copy link
Member

Dockerfile should not install DEV versions of shared libraries:

$ grep '@master' r*/Dockerfile
reana-server/Dockerfile:RUN pip install -e git://github.com/reanahub/reana-commons.git@master#egg=reana-commons
reana-server/Dockerfile:RUN pip install -e git://github.com/reanahub/reana-db.git@master#egg=reana-db
@tiborsimko tiborsimko mentioned this issue Aug 28, 2018
Closed
@tiborsimko tiborsimko added this to the v0.3.0 milestone Aug 28, 2018
tiborsimko added a commit to tiborsimko/reana-server that referenced this issue Sep 4, 2018
@tiborsimko
installation: setup.py for REANA-Commons and REANA-DB
ae2199b 
* Uses only `setup.py` to install REANA-Commons and REANA-DB dependencies and
  introduced upper boundary for their versions. (addresses reanahub/reana#80)

* Removes installation of their `master` versions from `Dockerfile`.
  (closes reanahub#85)

Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
@tiborsimko tiborsimko mentioned this issue Sep 4, 2018
Merged
@tiborsimko tiborsimko self-assigned this Sep 4, 2018
tiborsimko added a commit that referenced this issue Sep 4, 2018
@tiborsimko
installation: setup.py for REANA-Commons and REANA-DB
5600587 
* Uses only `setup.py` to install REANA-Commons and REANA-DB dependencies and
  introduces upper boundary for their versions. (addresses reanahub/reana#80)

* Removes installation of their `master` versions from `Dockerfile`.
  (closes #85)

Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
diegodelemos pushed a commit to diegodelemos/reana-server that referenced this issue Sep 5, 2018
installation: REANA dependencies version limits
1d941f5 
* Introduces upper boundary for REANA-Commons and REANA-DB dependencies.
  (addresses reanahub/reana#80)

* Removes installation of REANA-Commons from git master (closes reanahub#85).
@tiborsimko tiborsimko added this to Done in v0.3.0 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiborsimko tiborsimko

Labels
None yet
Projects
No open projects
v0.3.0
  
Done
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

installation: setup.py for REANA-Commons and REANA-DB tiborsimko/reana-server
2 participants
@tiborsimko @diegodelemos