Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow restart with different languages in same workspace #294

Merged
merged 1 commit into from Nov 6, 2020

Conversation

alintulu
Copy link
Member

@alintulu alintulu commented Oct 7, 2020

Adds reading the type of the workflow (Serial, CWL or Yadage) when restarting it

  1. From reana specification if provided
  2. From the original workflow

This allows you to restart workflow of different types in the same workspace.

Adds the operational option accept_metadir which allow overwriting the yadage meta directory _yadage (necessary if you want to restart a yadage workflow in a yadage workspace).

closes #293

Copy link
Member

@mvidalgarcia mvidalgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully running the following commands:

$ reana-client run -w test-serial-yadage
[INFO] Creating a workflow...
test-serial-yadage.1
[INFO] Uploading files...
File /code/helloworld.py was successfully uploaded.
File /data/names.txt was successfully uploaded.
[INFO] Starting workflow...
test-serial-yadage.1 has been queued

$ reana-client upload -w test-serial-yadage workflow/yadage 
File /workflow/yadage/workflow.yaml was successfully uploaded.

$ reana-client restart -w test-serial-yadage -f reana-yadage.yaml         
test-serial-yadage.1.1 has been queued

$ reana-client restart -w test-serial-yadage -f reana.yaml       
test-serial-yadage.1.2 has been queued

$ reana-client list                                                                                                                                                              
NAME                   RUN_NUMBER   CREATED               STARTED               ENDED                 STATUS  
test-serial-yadage     1.2          2020-10-22T14:56:07   2020-10-22T14:56:07   2020-10-22T14:56:25   finished
test-serial-yadage     1.1          2020-10-22T14:54:36   2020-10-22T14:54:36   2020-10-22T14:55:02   finished
test-serial-yadage     1            2020-10-22T14:53:27   2020-10-22T14:53:27   2020-10-22T14:53:45   finished

@alintulu
Copy link
Member Author

alintulu commented Nov 3, 2020

Rebased with maint-0.7

@alintulu alintulu changed the base branch from master to maint-0.7 November 3, 2020 17:33
@diegodelemos diegodelemos self-requested a review November 6, 2020 11:56
@diegodelemos diegodelemos merged commit 32ab3e2 into reanahub:maint-0.7 Nov 6, 2020
@diegodelemos diegodelemos removed their request for review November 6, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow restart with different languages
3 participants