fix(gitlab): redirect user to gitlab repo after click (#406) #406
Conversation
There was a problem hiding this comment.
The PR works well, good job! 🎉
There are a few small things that need to be done before merging:
-
Please add yourself to the list of authors in
AUTHORS.md -
We usually add the
Closes #...to both the PR description and the commit description. Could you addCloses #356also to the commit message? -
Regarding the commit title, I would make a small change to avoid repeating
gitlab:fix(gitlab): redirect user to repository after clicking on name (#406) -
Could you please add 2024 to the copyright notice at the top of the two files you have changed?
| @@ -171,7 +171,9 @@ export default function GitLabProjects() { | |||
| verticalAlign="middle" | |||
| /> | |||
| <List.Content> | |||
| <List.Header as="a">{name}</List.Header> | |||
| <List.Header as="a" href={url} target="_blank"> | |||
There was a problem hiding this comment.
We usually add rel="noopener noreferrer" to all the links, could you please add it also to the two links here? See for example:
reana-ui/reana-ui/src/pages/profile/components/GitLabProjects.js
Lines 210 to 214 in d403634
Alputer
force-pushed
the
fix-gitlab-redirection
branch
from
63b4ed6
to
9b0c589
Compare
Closes #356