Skip to content

Commit

Permalink
build(docker): non-editable submodules in "latest" mode (#551)
Browse files Browse the repository at this point in the history
When running development cluster in "latest" mode, install shared
modules in non-editable mode. The editable mode should be reserved only
for development clusters in "debug" mode with the live code reload.
  • Loading branch information
tiborsimko committed Jan 12, 2024
1 parent 672083d commit af74d0b
Showing 1 changed file with 16 additions and 4 deletions.
20 changes: 16 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,24 @@ COPY . /code

# Are we debugging?
ARG DEBUG=0
RUN if [ "${DEBUG}" -gt 0 ]; then pip --no-cache-dir install -e ".[debug]"; else pip install --no-cache-dir .; fi;
RUN if [ "${DEBUG}" -gt 0 ]; then pip install --no-cache-dir -e ".[debug]"; else pip install --no-cache-dir .; fi;

# Are we building with locally-checked-out shared modules?
# hadolint ignore=SC2102
RUN if test -e modules/reana-commons; then pip install --no-cache-dir -e modules/reana-commons[kubernetes] --upgrade; fi
RUN if test -e modules/reana-db; then pip install --no-cache-dir -e modules/reana-db --upgrade; fi
# hadolint ignore=DL3013
RUN if test -e modules/reana-commons; then \
if [ "${DEBUG}" -gt 0 ]; then \
pip install --no-cache-dir -e "modules/reana-commons[kubernetes]" --upgrade; \
else \
pip install --no-cache-dir "modules/reana-commons[kubernetes]" --upgrade; \
fi \
fi; \
if test -e modules/reana-db; then \
if [ "${DEBUG}" -gt 0 ]; then \
pip install --no-cache-dir -e "modules/reana-db" --upgrade; \
else \
pip install --no-cache-dir "modules/reana-db" --upgrade; \
fi \
fi

# Check for any broken Python dependencies
RUN pip check
Expand Down

0 comments on commit af74d0b

Please sign in to comment.