Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow-execution: reimplement workflow stop #157

Closed
diegodelemos opened this issue Dec 6, 2018 · 0 comments · Fixed by #171 or reanahub/reana-commons#79
Closed

workflow-execution: reimplement workflow stop #157

diegodelemos opened this issue Dec 6, 2018 · 0 comments · Fixed by #171 or reanahub/reana-commons#79

Comments

@diegodelemos
Copy link
Member

diegodelemos commented Dec 6, 2018

Currently, the workflow stop feature is implemented using an auxiliary celery task

On a serverless workflows architecture we won't have Celery service per engine, so we have two options:

  • Introduce a REANA-Worker (work is already started to have a REANA-Worker) who will use the mentioned task and it will: kill the dependent jobs as it is done right now, and reimplement the part of killing the workflow (revoke(workflow_uuid, terminate=True)) using Kubernetes API instead.
  • Since we already depend on Kubernetes, implement stop within the RWE_ itself, and take advantage of Kubernetes lifecycle hooks, using a PreStop hook which would do the clean-up.

Depends on #158.

@diegodelemos diegodelemos added this to the Serverless-Workflows milestone Dec 6, 2018
@diegodelemos diegodelemos self-assigned this Dec 14, 2018
diegodelemos pushed a commit to diegodelemos/reana-commons that referenced this issue Jan 18, 2019
* Stop workflow is fully implemented inside RWC now
  (closes reanahub/reana-workflow-controller#157).
@ghost ghost removed the Status: in review label Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants