rest: unify inputs/outputs/code to single dir #109
Conversation
diegodelemos
force-pushed
the
107-workspace-endpoint
branch
3 times, most recently
from
00a46ab
to
ca32249
Compare
docs/openapi.json
Outdated
| @@ -619,8 +619,8 @@ | |||
| }, | |||
| "/api/workflows/{workflow_id_or_name}/workspace": { | |||
| "get": { | |||
| "description": "This resource is expecting a workflow UUID and a filename to return its list of code|input|output files.", | |||
| "operationId": "get_workflow_files", | |||
| "description": "This resource is expecting a workflow run UUID which workspace file list will be retrieved.", | |||
There was a problem hiding this comment.
how about: "This resource retrieves the file list of a workspace, given its workflow run UUID."?
After reading everything I would suggest we go everywhere from workflow run workspace to just workspace, WDYT?
diegodelemos
force-pushed
the
107-workspace-endpoint
branch
2 times, most recently
from
61d15af
to
e35cf63
Compare
|
Commenting here, but really this is sth that could be done also in #111, the |
|
Probably we should stop doing this replace and standardise mounting the shared filesystem at one location (workflow controller mounts on |
diegodelemos
force-pushed
the
107-workspace-endpoint
branch
from
8ccaeba
to
bda904e
Compare
|
reanahub/reana-commons#28 needs to be merged to have this passing on Travis :) |
* Drops concept of input/output/code directories, so workspace is free to be organised as the user wants. Besides, any seeded file has as root the workflow run workspace.
* Renames endpoint so workspace directly contains all files.
* Drops listing files per type (inputs/outputs/code), instead treats the workspace as the global root.
* Replaces all references of workflow run to workflow. * Simplifies OpenAPI operationId's.
* reanahub/reana-cluster@22603c1 standardises REANA shared FS mount path so this fix is no longer needed.
diegodelemos
force-pushed
the
107-workspace-endpoint
branch
from
bda904e
to
0b7c5ff
Compare
Closes #107.
Depends on reanahub/reana-commons#28.