k8s: delete completed pods #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
tiborsimko
reviewed
Jan 17, 2019
| @@ -89,5 +89,6 @@ def _create_job_spec(self, name, command=None, image=None, | |||
| ] | |||
| job.spec = spec | |||
| job.spec.template.spec.restart_policy = 'Never' | |||
| job.spec.ttl_seconds_after_finished = 60 | |||
There was a problem hiding this comment.
Please introduce a variable in the main config.py and just import it here.
* Setting ttl_seconds_after_finished = 60, to delete completed pods. Closes reanahub/reana-workflow-engine-serial/issues/58 Signed-off-by: Rokas Maciulaitis <rokas.maciulaitis@cern.ch>
roksys
force-pushed
the
58-remove-completed-pods
branch
from
8f0b6f1
to
19e9207
Compare
tiborsimko
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pods. Closes remove
Completedpods reana-workflow-engine-serial#58Signed-off-by: Rokas Maciulaitis rokas.maciulaitis@cern.ch