interactive-execution: backend independent #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
diegodelemos
force-pushed
the
interactive-session-backend-independent
branch
from
16ca4c5
to
4f52f5a
Compare
diegodelemos
force-pushed
the
interactive-session-backend-independent
branch
2 times, most recently
from
77d47d3
to
4d50bbb
Compare
diegodelemos
force-pushed
the
interactive-session-backend-independent
branch
from
4d50bbb
to
ea66467
Compare
diegodelemos
force-pushed
the
interactive-session-backend-independent
branch
from
ea66467
to
0a99e80
Compare
diegodelemos
force-pushed
the
interactive-session-backend-independent
branch
from
0a99e80
to
b6d3224
Compare
diegodelemos
force-pushed
the
interactive-session-backend-independent
branch
2 times, most recently
from
c5e7b9e
to
f5511f4
Compare
roksys
approved these changes
Mar 5, 2019
| @@ -135,6 +140,7 @@ def _workflow_engine_command(self): | |||
| ['command'].format( | |||
| id=self.workflow.id_, | |||
| workspace=self.workflow.get_workspace(), | |||
|
|
|||
There was a problem hiding this comment.
Is there need for this blank line?
diegodelemos
force-pushed
the
interactive-session-backend-independent
branch
from
f5511f4
to
8180da3
Compare
added 3 commits
March 6, 2019 08:12
* Interactive session backend indepdendent set up. * Refactors the way interactive Kubernetes deployment objects are built, from template file (error prone) to native Kubernetes library wrapped with a builder pattern.
* Interactive sessions were leaving hanging Kubernetes objects when some of them could not be created. Let say that the following needed to be created in order: Ingress, Service and Deployment. When the creation of Service failed, hanging Ingresses were left behind as well as marked in DB as successfully deployed.
diegodelemos
force-pushed
the
interactive-session-backend-independent
branch
from
8180da3
to
0ffb1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-client#258.