secrets: pass reana user id to workflow engines #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
okraskaj
commented
Jun 18, 2019
okraskaj
commented
- addresses jobs: mounting user secrets inside jobs reana-job-controller#147
okraskaj
force-pushed
the
secrets
branch
3 times, most recently
from
81806ec
to
c232f52
Compare
diegodelemos
reviewed
Jul 2, 2019
| job_controller_container.volume_mounts = [ | ||
| { | ||
| 'name': 'default-shared-volume', | ||
| 'mountPath': SHARED_FS_MAPPING['MOUNT_DEST_PATH'], | ||
| }, | ||
| { | ||
| 'name': owner_id, | ||
| 'mountPath': "/etc/reana/secrets", |
There was a problem hiding this comment.
We should extract this to configuration, also in https://github.com/reanahub/reana-job-controller/pull/158/files#diff-669c9f342cac1a455e5c652c40abf085R130.
Package configuration for now, once we merge we create an issue to move it to REANA-Commons.
diegodelemos
reviewed
Jul 2, 2019
| @@ -358,12 +365,42 @@ def _create_job_spec(self, name, command=None, image=None, | |||
| if os.getenv('FLASK_ENV') == 'development': | |||
| job_controller_env_vars.extend( | |||
| current_app.config['DEBUG_ENV_VARS']) | |||
| job_controller_env_vars.extend([{ | |||
There was a problem hiding this comment.
The code here and here https://github.com/reanahub/reana-job-controller/pull/158/files#diff-669c9f342cac1a455e5c652c40abf085R103 is very similar, we should create a refactor issue pointing to this code once merged.
diegodelemos
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.