Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow_run_manager: RJC & RWE as a sidecar #213

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

roksys
Copy link
Contributor

@roksys roksys commented Jun 19, 2019

@roksys roksys self-assigned this Jun 19, 2019
@roksys roksys added this to In progress in Condor-Slurm-Demo via automation Jun 19, 2019
@roksys roksys force-pushed the 105-job-controller-as-sidecar branch from 3ddc931 to d34fdf9 Compare June 20, 2019 13:10
@roksys roksys moved this from In progress to Review in progress in Condor-Slurm-Demo Jun 20, 2019
@roksys roksys force-pushed the 105-job-controller-as-sidecar branch from d34fdf9 to 2dfd9b3 Compare June 20, 2019 13:16
"""Default container port for Reana Job Controller sidecar."""

JOB_CONTROLLER_NAME = 'job-controller'
"""Default container port for Reana Job Controller sidecar."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong docstring

@roksys roksys force-pushed the 105-job-controller-as-sidecar branch from 2dfd9b3 to 911bc0f Compare June 20, 2019 14:24
@roksys roksys force-pushed the 105-job-controller-as-sidecar branch from 911bc0f to 401848a Compare June 20, 2019 15:44
* Run RJC and RWE in the same pod.
  Connects reanahub/reana-job-controller/issues/105

Signed-off-by: Rokas Maciulaitis <rokas.maciulaitis@cern.ch>
@roksys roksys force-pushed the 105-job-controller-as-sidecar branch from 401848a to 931fb0f Compare June 21, 2019 06:44
Condor-Slurm-Demo automation moved this from Review in progress to Reviewer approved Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants