workflow_run_manager: fix workflow stop #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
force-pushed
the
314-stop-workflow-fix
branch
3 times, most recently
from
6a6a731
to
d1f81e1
Compare
diegodelemos
moved this from In progress
to Review in progress
in Physics-Examples-Summer-2019
* We were trying to delete Job IDs which didn't exist in Kubernetes. To fix this a new method has been added to resolve the REANA IDs to backend IDs, which will be helpful once we implement stop for HTCondor jobs (closes reanahub/reana-client#314).
diegodelemos
force-pushed
the
314-stop-workflow-fix
branch
from
d1f81e1
to
3e0dc7d
Compare
Physics-Examples-Summer-2019
automation
moved this from Review in progress
to Reviewer approved
Sep 2, 2019
dprelipcean
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
LGTM:
(reana) dprelipc@daniel-main:~/project/reana/reana-demo-helloworld$ reana-client status -w workflow.1
/home/dprelipc/.virtualenvs/reana/lib/python3.6/site-packages/urllib3/connectionpool.py:851: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
InsecureRequestWarning)
NAME RUN_NUMBER CREATED STATUS PROGRESS
workflow 1 2019-09-02T16:48:37 running 0/1
(reana) dprelipc@daniel-main:~/project/reana/reana-demo-helloworld$ reana-client stop -w workflow.1
Graceful stop not implement yet. If you really want to stop your workflow without waiting for jobs to finish use: --force option
Aborted!
(reana) dprelipc@daniel-main:~/project/reana/reana-demo-helloworld$ reana-client stop --force -w workflow.1
/home/dprelipc/.virtualenvs/reana/lib/python3.6/site-packages/urllib3/connectionpool.py:851: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
InsecureRequestWarning)
workflow.1 has been stopped
(reana) dprelipc@daniel-main:~/project/reana/reana-demo-helloworld$ reana-client status -w workflow.1
/home/dprelipc/.virtualenvs/reana/lib/python3.6/site-packages/urllib3/connectionpool.py:851: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
InsecureRequestWarning)
NAME RUN_NUMBER CREATED STATUS PROGRESS
workflow 1 2019-09-02T16:48:37 stopped 0/1
`| @@ -293,15 +303,15 @@ def stop_interactive_session(self): | |||
| current_db_sessions.add(self.workflow) | |||
| current_db_sessions.commit() | |||
|
|
|||
| def stop_batch_workflow_run(self, workflow_run_jobs=None): | |||
| def stop_batch_workflow_run(self): | |||
| """Stop a batch workflow run along with all its dependent jobs. | |||
|
|
|||
| :param workflow_run_jobs: List of active job id's spawned by the | |||
| workflow run. | |||
| """ | |||
There was a problem hiding this comment.
docs: remove workflow_run_jobs as it's not needed anymore
added 2 commits
September 3, 2019 11:42
* WorkflowRunManger can determine which jobs to delete by itself.
* pytest-reana declares as dependency `mock>=2` and Travis installs 2.0 instead of lasted one (3.x). To be removed once we upgrade the `mock` version in pytest-reana.
diegodelemos
force-pushed
the
314-stop-workflow-fix
branch
from
de65b3d
to
4031516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.