Revert "consumer: removes unused task" #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 441e28b. * We are correctly using the [TTLSecondsAfterFinished](https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished), and it really works, but the subtle detail is that RJC never finishes. One can see this by checking how many ready containers are inside the pod, Workflow Engine finishes and RJC still runs, see: ```console $ kubectl get pod \ batch-serial-a0f3f1c4-161d-461c-94e0-c4dae1000b2f-nv8bb -o json | \ jq '.status.containerStatuses[] | .name + " " + (.ready|tostring)' "job-controller true" "workflow-engine false" ``` Because of this we need to manually delete the batch- containers with the task that was removed in the previous commit (closes reanahub#258).
tiborsimko
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 441e28b.
TTLSecondsAfterFinished,
and it really works, but the subtle detail is that RJC never
finishes. One can see this by checking how many ready containers
are inside the pod, Workflow Engine finishes and RJC still runs,
see:
with the task that was removed in the previous commit
(closes workflow_run_manager: batch workflows not being cleaned-up #258).