k8s: fixes after k8s upgrade #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roksys
commented
Nov 29, 2019
roksys
commented
- Closes tests: fix 5 failing tests #265
roksys
force-pushed
the
265-fixes-after-k8s-update
branch
from
9a5e9be
to
00fd36e
Compare
tiborsimko
reviewed
Nov 29, 2019
| @@ -51,7 +51,7 @@ | |||
| 'jsonpickle>=0.9.6', | |||
| 'marshmallow>2.13.0,<=2.20.1', | |||
| 'packaging>=18.0', | |||
| 'reana-commons[kubernetes]>=0.6.0.dev20191128,<0.7.0', | |||
| 'reana-commons[kubernetes]>=0.6.0.dev20191129,<0.7.0', | |||
There was a problem hiding this comment.
This kind of version upgrade is good to do after the reana-commons is released on PyPI... Otherwise one cannot test locally without amending it...
tiborsimko
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.