workflow_run_manager: changes workspace group #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roksys
commented
Dec 12, 2019
roksys
commented
- Addresses k8s: auto-discover appropriate runtime UID/GID #269
roksys
force-pushed
the
user-settable-uid
branch
from
82b5a41
to
c170ff4
Compare
tiborsimko
reviewed
Dec 13, 2019
| WORKFLOW_RUNTIME_USER_UID, | ||
| WORKFLOW_RUNTIME_USER_GID, |
There was a problem hiding this comment.
If we have WORKFLOW_RUNTIME_USER_UID set to 1000 by default, and if a user specifies kubernetes_uid=500 in the workflow definition, will the workspace be writable? Thanks to GID=0 it might, but I wonder whether the kubernetes_uid and (future) kubernetes_gid should be consumed already here in R-W-C if we do any kind of chmod/chown stuff...
tiborsimko
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Integration OK with:
- reana-workflow-controller @ pr-271 @ c170ff4 workflow_run_manager: changes workspace group
- reana-workflow-engine-serial @ pr-91 @ 8978e4e utils: deletes experiment field from job request
- reana-workflow-engine-cwl @ pr-127 @ 5aca7e8 docs: fixes docstrings for init methods
- reana-job-controller @ pr-207 @ 458dd1c rest: cleans job request & allows overwriting uid
- reana-workflow-engine-yadage @ pr-131 @ 3e94232 cli: sets default umask
- reana-commons @ pr-153 @ 3ef2763 release: 0.6.0.dev20191212
- reana-client @ pr-332 @ 63cc008 cli: refactors connection check
This was referenced Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.