workflow_run: notify about third party failures #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
force-pushed
the
r/253-requeue-on-db-failure
branch
3 times, most recently
from
3d8bd8b
to
d63a600
Compare
diegodelemos
force-pushed
the
r/253-requeue-on-db-failure
branch
3 times, most recently
from
fbf244a
to
0692206
Compare
roksys
reviewed
Jan 22, 2020
roksys
reviewed
Jan 22, 2020
diegodelemos
force-pushed
the
r/253-requeue-on-db-failure
branch
2 times, most recently
from
5926c08
to
5c538b0
Compare
* Notifies RWC clients (in this case RS) that something went wrong while connecting to an external system to start a workflow, it is responsibility of the client to act accordignly. In the case of RS, it should requeue the workflow and retry later (addresses reanahub/reana#253). * Allows overwriting parameters when calling the workflow run manager directory. If we don't allow overwriting the operational options or parameters when calling `start_batch_workflow_run`, there is a hidden dependency, the KubernetesWorkflowRunManager will infer these values from DB, creating an order dependency (DB transaction has to happen before a workflow run is sent to Kubernetes). Now we can do Kubernetes action before DB transaction, that way when we change the status in the DB, the workflow will be really running.
diegodelemos
force-pushed
the
r/253-requeue-on-db-failure
branch
from
5c538b0
to
fe8dee8
Compare
roksys
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana#253.