global: changes get_workspace method with workspace_path field #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roksys
force-pushed
the
workspace-path
branch
4 times, most recently
from
e4eaee5
to
ce2db39
Compare
roksys
force-pushed
the
workspace-path
branch
from
ce2db39
to
fbcfdbf
Compare
roksys
force-pushed
the
workspace-path
branch
5 times, most recently
from
585f093
to
9ef854f
Compare
* It allows reuse of workspace. * Addresses reanahub/issues/289
roksys
force-pushed
the
workspace-path
branch
from
9ef854f
to
75e7348
Compare
diegodelemos
approved these changes
Feb 5, 2020
tiborsimko
reviewed
Feb 5, 2020
| @@ -179,7 +179,7 @@ def _workflow_engine_command(self, overwrite_input_parameters=None, | |||
| return (WorkflowRunManager.engine_mapping[self.workflow.type_] | |||
| ['command'].format( | |||
| id=self.workflow.id_, | |||
| workspace=self.workflow.get_workspace(), | |||
| workspace=self.workflow.workspace_path, | |||
There was a problem hiding this comment.
We can now upgrade the minimal version of reana-db to 0.7.0.dev20200205 in setup.py.
roksys
force-pushed
the
workspace-path
branch
2 times, most recently
from
3351a8f
to
cfc85b7
Compare
* Saves workflow engine container logs and updates WF status if it is only needed.
roksys
force-pushed
the
workspace-path
branch
from
cfc85b7
to
88ea799
Compare
tiborsimko
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows reuse of workspace.
Addresses refactor: workflow restart/rerun using the same workspace #289