rest: load json boolean #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
reviewed
Feb 6, 2020
| @@ -155,7 +155,7 @@ def get_workflows(): # noqa | |||
| user_uuid = request.args['user'] | |||
| user = User.query.filter(User.id_ == user_uuid).first() | |||
| type = request.args.get('type', 'batch') | |||
| verbose = request.args.get('verbose', False) | |||
| verbose = json.loads(request.args.get('verbose', 'false').lower()) | |||
There was a problem hiding this comment.
Do we have the same issue with the following?
reana_workflow_controller/rest/workflows.py:554: brief = request.args.get('brief', False)
* `true` and `false` when passed to `bool()` are always true (closes reanahub/reana-client#367).
diegodelemos
force-pushed
the
reana-367/optimise-list-performance
branch
from
99d30a6
to
acb5176
Compare
* New version 1.0 of Werkzeug released.
tiborsimko
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trueandfalsewhen passed tobool()are always true(closes cli: optimise
listcommand performance reana-client#367).