Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rest: allows to delete queued workflows #296

Merged
merged 1 commit into from Feb 7, 2020
Merged

rest: allows to delete queued workflows #296

merged 1 commit into from Feb 7, 2020

Conversation

roksys
Copy link
Contributor

@roksys roksys commented Feb 7, 2020 •
edited

diegodelemos
diegodelemos reviewed Feb 7, 2020
View reviewed changes
reana_workflow_controller/rest/utils.py
_delete_workflow_row_from_db(workflow)
else:
if workspace:
WorkflowStatus.failed,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you confirm what is happening with the reana-server scheduler container? Because we have this operation to delete from the DB, but the workflow will still be present in the RabbitMQ queue... (which one can check with rabbitmqctl list_queues inside the message-broker component).

I am afraid that reana-server will continuously try to start the workflow, fail, requeue, try to start, fail, requeue... infinitely.

If that is the case, I feel we need to find a nice way of doing this operation atomically (RabbitMQ and DB).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is solving this.

@roksys roksys force-pushed the 239-delete-queued-wf branch 2 times, most recently from 4ac4822 to bdfae2b Compare February 7, 2020 15:17
@diegodelemos
Copy link
Member

Can you rebase? I will test it :)

rest: allows to delete queued workflows
ba1575e 
* In case of trying to start deleted workflow returns 404.
  Closes reanahub/reana-client/issues/239
@diegodelemos diegodelemos merged commit ba1575e into reanahub:master Feb 7, 2020
@diegodelemos diegodelemos added this to Done in Awesome-Workshop-Basics via automation Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegodelemos diegodelemos diegodelemos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Awesome-Workshop-Basics
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: delete queued workflow
2 participants
@roksys @diegodelemos