Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: REANA_URL -> REANA_HOSTNAME #331

Merged
merged 1 commit into from
Sep 16, 2020
Merged

config: REANA_URL -> REANA_HOSTNAME #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion reana_workflow_controller/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
REANA_GITLAB_URL = "https://{}".format(REANA_GITLAB_HOST)
"""GitLab API URL"""

REANA_URL = os.getenv("REANA_URL", "CHANGE_ME")
REANA_HOSTNAME = os.getenv("REANA_HOSTNAME", "CHANGE_ME")
"""REANA URL"""

IMAGE_PULL_SECRETS = os.getenv("IMAGE_PULL_SECRETS", "").split(",")
Expand Down
4 changes: 2 additions & 2 deletions reana_workflow_controller/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
from reana_workflow_controller.config import (
PROGRESS_STATUSES,
REANA_GITLAB_URL,
REANA_URL,
REANA_HOSTNAME,
)
from reana_workflow_controller.errors import REANAWorkflowControllerError

Expand Down Expand Up @@ -127,7 +127,7 @@ def _update_commit_status(workflow, status):
state = "running"
secret_store = REANAUserSecretsStore(workflow.owner_id)
gitlab_access_token = secret_store.get_secret_value("gitlab_access_token")
target_url = f"https://{REANA_URL}/api/workflows/{workflow.id_}/logs"
target_url = f"https://{REANA_HOSTNAME}/api/workflows/{workflow.id_}/logs"
workflow_name = urlparse.quote_plus(workflow.git_repo)
commit_status_url = (
f"{REANA_GITLAB_URL}/api/v4/projects/{workflow_name}/statuses/"
Expand Down