Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add initialize workflow endpoint #40

Merged

Conversation

diegodelemos
Copy link
Member

@diegodelemos diegodelemos commented Oct 20, 2017

@@ -157,8 +206,7 @@
"description": "Request succeeded. The file has been added to the workspace.",
"examples": {
"application/json": {
"message": "Workflow has been added to the workspace",
"workflow_id": "cdcf48b1-c2f3-4693-8230-b066e088c6ac"
"message": "The file input.txt has been successfully transferred."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better input.csv or input.dat instead of .txt... but we can use some consistent examples across REANA, see mydata.csv, mycode.py etc used in musings elsewhere.

@diegodelemos diegodelemos force-pushed the workflowspace-bootstrapping branch 2 times, most recently from 70d2ab3 to a95c272 Compare October 26, 2017 11:30
@diegodelemos diegodelemos force-pushed the workflowspace-bootstrapping branch 2 times, most recently from d01eb91 to b6968c9 Compare October 26, 2017 12:17
Copy link
Contributor

@hjhsalo hjhsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

application/json:
{
"message": "Workflow workspace has been created.",
"workflow_id": "cdcf48b1-c2f3-4693-8230-b066e088c6ac"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this payload include a name of the workflow in the future?

Signed-off-by: Diego Rodriguez <diego.rodriguez@cern.ch>
@diegodelemos diegodelemos merged commit 93eaf55 into reanahub:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants