api: return 404 when file does not exist #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
reviewed
Jan 15, 2018
| @@ -652,10 +652,10 @@ | |||
| "description": "Request failed. The incoming data specification seems malformed." | |||
| }, | |||
| "404": { | |||
| "description": "Request failed. User doesn't exist.", | |||
| "description": "Request failed. `file_name` does not exist.", | |||
| "examples": { | |||
There was a problem hiding this comment.
Please amend also surrounding inputs/outputs cases...
tiborsimko
approved these changes
Jan 15, 2018
added 2 commits
January 15, 2018 16:22
* Fixes error messages and amends documentation.
diegodelemos
force-pushed
the
return-404-when-file-dosnt-exist
branch
from
3dc9b77
to
494f38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.