global: models from reana-commons #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosk
force-pushed
the
models-from-reana-commons
branch
from
d078192
to
a7f930e
Compare
dinosk
commented
Apr 23, 2018
reana_workflow_controller/config.py
Outdated
| ORGANIZATIONS = os.getenv('ORGANIZATIONS').split(',') \ | ||
| if os.getenv('ORGANIZATIONS') else [] | ||
| """Organizations.""" | ||
| SQLALCHEMY_DATABASE_URI = 'sqlite:///' |
There was a problem hiding this comment.
TODO: change from sqlite:/// to postgres..., make the tests work with the URI defined in conftest.py
dinosk
force-pushed
the
models-from-reana-commons
branch
13 times, most recently
from
bda6316
to
e93d049
Compare
diegodelemos
force-pushed
the
models-from-reana-commons
branch
from
6329f3d
to
4533898
Compare
|
@dinosk can you have a look look to the latest changes? |
diegodelemos
force-pushed
the
models-from-reana-commons
branch
from
4533898
to
8b731da
Compare
* Uses models from reana-commons * Factory: addition of scoped_session * ADD an engine fixture so that the URI define in the test app is used. Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
diegodelemos
force-pushed
the
models-from-reana-commons
branch
from
8b731da
to
acbf03c
Compare
diegodelemos
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dinos Kousidis dinos.kousidis@cern.ch