factory: remove session on appcontext teardown #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
force-pushed
the
close-db-connection
branch
from
15b9478
to
8a66e89
Compare
diegodelemos
force-pushed
the
close-db-connection
branch
from
8a66e89
to
06342fd
Compare
dinosk
force-pushed
the
close-db-connection
branch
from
06342fd
to
834cf04
Compare
* Since we are using SQLAlchemy declarative directly, we need to take care of the session lifecylce, closing it when the app tearsdown.
dinosk
force-pushed
the
close-db-connection
branch
from
834cf04
to
5689c57
Compare
dinosk
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.