Skip to content

Commit

Permalink
build(docker): non-editable submodules in "latest" mode (#73)
Browse files Browse the repository at this point in the history
When running development cluster in "latest" mode, install shared
modules in non-editable mode. The editable mode should be reserved only
for development clusters in "debug" mode with the live code reload.
  • Loading branch information
tiborsimko committed Jan 12, 2024
1 parent 9b16bd0 commit c3595c2
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,14 @@ ARG DEBUG=0
RUN if [ "${DEBUG}" -gt 0 ]; then pip install --no-cache-dir -e ".[debug,xrootd]"; else pip install --no-cache-dir ".[xrootd]"; fi;

# Are we building with locally-checked-out shared modules?
# hadolint ignore=SC2102
RUN if test -e modules/reana-commons; then pip install --no-cache-dir -e modules/reana-commons[kubernetes] --upgrade; fi
# hadolint ignore=DL3013
RUN if test -e modules/reana-commons; then \
if [ "${DEBUG}" -gt 0 ]; then \
pip install --no-cache-dir -e "modules/reana-commons[kubernetes]" --upgrade; \
else \
pip install --no-cache-dir "modules/reana-commons[kubernetes]" --upgrade; \
fi \
fi

# Check for any broken Python dependencies
RUN pip check
Expand Down

0 comments on commit c3595c2

Please sign in to comment.