New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
externalbackend: reverts back cmd encoding #129
Conversation
8649ee4
to
680b4c4
Compare
Signed-off-by: Rokas Maciulaitis <rokas.maciulaitis@cern.ch>
680b4c4
to
adb65a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can't successfully run the BSM search, I get permission errors at the end of the analysis:
Traceback (most recent call last):
File "/code/hepdata_export.py", line 53, in <module>
main()
File "/code/hepdata_export.py", line 45, in main
with open('submission.yaml','w') as f:
IOError: [Errno 13] Permission denied: 'submission.yaml'
zip warning: name not matched: submission.yaml
zip warning: name not matched: data1.yam
and
Traceback (most recent call last):
File "/usr/local/bin/hfquickplot", line 9, in <module>
load_entry_point('hftools==0.0.6', 'console_scripts', 'hfquickplot')()
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 722, in __call__
return self.main(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/hftools/plotting/quickplot_cli.py", line 112, in fit
save_pars(ws,output,False)
File "/usr/local/lib/python2.7/dist-packages/hftools/plotting/quickplot_cli.py", line 51, in save_pars
with open(output,'w') as results:
IOError: [Errno 13] Permission denied: u'fitresults.yml'
Do you know about them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for small demo workflows.
For a BSM workflow, I get:
$ reana-client status -w bsm-search.serial
NAME RUN_NUMBER CREATED STATUS PROGRESS
bsm-search.serial 1 2019-09-13T14:53:17 failed 65/65
$ reana-client logs -w bsm-search.serial
[#0] WARNING:InputArguments -- RooAbsReal::createHistogram(L_x_qcd_channel1_overallSyst_x_Exp) WARNING extended mode requested for a non-pdf object, ignored
[#1] INFO:InputArguments -- RooAbsReal::createHistogram(L_x_qcd_channel1_overallSyst_x_Exp) INFO: Model has intrinsic binning definition, selecting that binning for the histogram
Traceback (most recent call last):
File "/code/hepdata_export.py", line 53, in <module>
main()
File "/code/hepdata_export.py", line 45, in main
with open('submission.yaml','w') as f:
IOError: [Errno 13] Permission denied: 'submission.yaml'
zip warning: name not matched: submission.yaml
zip warning: name not matched: data1.yaml
zip error: Nothing to do! (/var/reana/users/00000000-0000-0000-0000-000000000000/workflows/3d2508ae-c771-4cb5-be8f-b030a275dc23/hepdata/submission.zip)
Perhaps something else needs checking/reverting?
(recall that BSM adds steps as it goes...)
BTW the images use uid=0(root) gid=0(root) groups=0(root) still... |
This PR reverts back CMD encoding which was deleted in e4d0cb4
Signed-off-by: Rokas Maciulaitis rokas.maciulaitis@cern.ch