Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(commitlint): check for the presence of concrete PR number #257

Merged
merged 2 commits into from Jan 26, 2024
Merged

ci(commitlint): check for the presence of concrete PR number #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8831d9e
ci(shellcheck): fix exit code propagation (#257)
tiborsimko Jan 25, 2024
9ddb488
ci(commitlint): check for the presence of concrete PR number (#257)
tiborsimko Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Check commit message compliance of the pull request
if: github.event_name == 'pull_request'
run: |
./run-tests.sh --check-commitlint ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} ${{ github.event.pull_request.head.sha }}
./run-tests.sh --check-commitlint ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} ${{ github.event.pull_request.head.sha }} ${{ github.event.pull_request.number }}

lint-shellcheck:
runs-on: ubuntu-20.04
Expand Down
7 changes: 4 additions & 3 deletions run-tests.sh
View file
Open in desktop
Expand Up @@ -12,13 +12,14 @@ set -o nounset
check_commitlint () {
from=${2:-master}
to=${3:-HEAD}
pr=${4:-[0-9]+}
npx commitlint --from="$from" --to="$to"
found=0
while IFS= read -r line; do
if echo "$line" | grep -qP "\(\#[0-9]+\)$"; then
if echo "$line" | grep -qP "\(\#$pr\)$"; then
true
else
echo "✖ PR number missing in $line"
echo "✖ Headline does not end by '(#$pr)' PR number: $line"
found=1
fi
done < <(git log "$from..$to" --format="%s")
Expand All @@ -28,7 +29,7 @@ check_commitlint () {
}

check_shellcheck () {
find . -name "*.sh" -exec shellcheck {} \;
find . -name "*.sh" -exec shellcheck {} \+
}

check_pydocstyle () {
Expand Down