global: import models from reana-commons #58
Merged
+14
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosk
force-pushed
the
models-from-reana-commons
branch
2 times, most recently
from
8f5a854
to
aee0856
Compare
tiborsimko
reviewed
Apr 26, 2018
setup.py
Outdated
| @@ -72,6 +72,7 @@ | |||
| 'adage==0.8.5', | |||
| 'packtivity==0.10.0', | |||
| 'yadage==0.13.5', | |||
| 'psycopg2-binary>=2.6.1', | |||
There was a problem hiding this comment.
I think the PostgreSQL dependencies will be coming indirectly via reana-commons... So perhaps you can already start to proactively declare reana-commons as a dependency in setup.py, and we would just modify Dockerfile to pip-install it from github via requirements-dev.txt until the times reana-commons is released on PyPI... Seems more forward-friendly?
There was a problem hiding this comment.
Yes exactly, and that's a good idea, I'll go with this
tiborsimko
reviewed
Apr 26, 2018
| @@ -29,15 +29,15 @@ | |||
| from yadage.steering_api import steering_ctx | |||
| from yadage.utils import setupbackend_fromstring | |||
|
|
|||
| from reana_commons.models import Workflow, WorkflowStatus | |||
There was a problem hiding this comment.
Please invert the two lines to make isort in Travis CI happy
dinosk
force-pushed
the
models-from-reana-commons
branch
5 times, most recently
from
da8f5df
to
f46778a
Compare
|
@dinosk can you have a look look to the latest changes? |
diegodelemos
force-pushed
the
models-from-reana-commons
branch
from
4bb0f0a
to
b32dc12
Compare
diegodelemos
approved these changes
May 2, 2018
diegodelemos
force-pushed
the
models-from-reana-commons
branch
from
b32dc12
to
ed0455c
Compare
Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
diegodelemos
force-pushed
the
models-from-reana-commons
branch
from
ed0455c
to
a8821bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dinos Kousidis dinos.kousidis@cern.ch