Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: reana-dev git-status -s #112

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

tiborsimko
Copy link
Member

  • Introduces -s option to git-status command in order to show the git short
    status overview for components.

Signed-off-by: Tibor Simko tibor.simko@cern.ch

@tiborsimko tiborsimko added this to the Live-Mode milestone Nov 20, 2018
@tiborsimko tiborsimko self-assigned this Nov 20, 2018
@ghost ghost added the Status: in review label Nov 20, 2018
reana/cli.py Outdated
@@ -594,6 +601,9 @@ def git_status(component): # noqa: D301
click.secho(' @ {0} {1}'.format(branch, commit))
else:
click.secho(' @ {0} {1}'.format(branch, commit), fg='red')
if short:
cmd = 'git status -s'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe use the more verbose mode git status --short so it is more descriptive and easy to read.

Copy link
Member

@diegodelemos diegodelemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Introduces `-s` option to `git-status` command in order to show the git short
  status overview for components.

Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
@diegodelemos diegodelemos merged commit 6618293 into reanahub:master Nov 20, 2018
@ghost ghost removed the Status: in review label Nov 20, 2018
@tiborsimko tiborsimko deleted the cli-git-status-short branch November 20, 2018 13:19
@tiborsimko tiborsimko added this to Done in Live-Mode Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Live-Mode
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants