helm: add reana secret key #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidalgarcia
commented
May 19, 2020
| @@ -93,6 +93,11 @@ spec: | |||
| secretKeyRef: | |||
| name: {{ include "reana.prefix" . }}-cern-gitlab-secrets | |||
| key: REANA_GITLAB_HOST | |||
| - name: REANA_SECRET_KEY | |||
There was a problem hiding this comment.
Do I need to add this env also in reana-workflow-controller.yaml? I see there are other cases in both templates such us REANA_DB_USERNAME.
There was a problem hiding this comment.
In principle, we do not access user.access_token anywhere else than in RS, if SQLAlchemy doesn't need it (does lazy loading) we can skip adding it there (the fewer places we have this key loaded the best from a security point of view). I would say it needs testing.
There was a problem hiding this comment.
How would you test it?
mvidalgarcia
force-pushed
the
r-db/66-encrypt-token
branch
from
01f2f88
to
7ce593c
Compare
diegodelemos
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes reanahub/reana-db#66
reana-dev setup-environmentproblem (encrypted token output) still need to be addressed or ticketized.