Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind multinode opt mount #344

Merged
merged 5 commits into from
Jun 26, 2020

Conversation

diegodelemos
Copy link
Member

No description provided.

@diegodelemos diegodelemos marked this pull request as ready for review June 24, 2020 14:41
reana/cli.py Outdated Show resolved Hide resolved
reana/cli.py Outdated Show resolved Hide resolved
reana/cli.py Outdated Show resolved Hide resolved
reana/cli.py Outdated Show resolved Hide resolved
reana/cli.py Outdated Show resolved Hide resolved
reana/cli.py Outdated Show resolved Hide resolved
reana/cli.py Outdated Show resolved Hide resolved
reana/cli.py Outdated
@@ -1687,15 +1780,16 @@ def cluster_undeploy(): # noqa: D301
help="Destroy and recreate cluster from scratch?",
)
@cli.command(name="run-ci")
def run_ci(mount, recreate): # noqa: D301
def run_ci(mounts, recreate): # noqa: D301
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the mount options are only used during cluster creation time, one cannot easily change mount? do-not-mount? decision once the cluster is created. So perhaps we can move the recreate command to cluster-create so that we don't have to duplicate all these arguments?

This would mean people will have to do:

$ reana-dev cluster-create
$ reana-dev run-ci
$ reana-dev cluster-delete

manually.

If it seems OK, then we should do:

  • enrich cluster-create so that it does docker-pulling and kind-load-docker-image steps after cluster creation;
  • leave out cluster-delete step, people will have to do it manually
  • remove mount, recreate option from run-ci, because there were consumed already
  • enrich run-ci options with --debug flag so that docker images would be built with DEBUG flag

@diegodelemos diegodelemos force-pushed the kind-multinode-opt-mount branch 3 times, most recently from 0dcdf0b to e246987 Compare June 25, 2020 15:21
reana/cli.py Outdated Show resolved Hide resolved
@diegodelemos diegodelemos force-pushed the kind-multinode-opt-mount branch 2 times, most recently from 79cf7e3 to 3f3fbc6 Compare June 26, 2020 06:24
* Enables mounting custom paths into job pods.
@tiborsimko tiborsimko merged commit d17b34f into reanahub:kind Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants