cli: add helm release management command #361
Conversation
diegodelemos
force-pushed
the
331-tags-and-versions
branch
3 times, most recently
from
987881f
to
edba0c7
Compare
diegodelemos
changed the title
diegodelemos
force-pushed
the
331-tags-and-versions
branch
2 times, most recently
from
867e9ab
to
4829270
Compare
diegodelemos
force-pushed
the
331-tags-and-versions
branch
from
4829270
to
ed35697
Compare
reana/reana_dev/release.py
Outdated
| next_version=version, | ||
| ) | ||
|
|
||
| ctx.invoke(git_create_release_commit_command, component=["reana"], version=version) |
There was a problem hiding this comment.
I wonder whether these two should be part of the release-helm command. E.g. making PRs is not part of release-pypi and release-docker commands, so perhaps let's not use them here as well? That said, the first command to create release commit is perhaps good to keep, but creating the PR is perhaps too much; need local testing first?
diegodelemos
force-pushed
the
331-tags-and-versions
branch
from
ed35697
to
ee3f23b
Compare
diegodelemos
force-pushed
the
331-tags-and-versions
branch
from
ee3f23b
to
c934ef7
Compare
reana/reana_dev/release.py
Outdated
| f"{user}/{component}:{get_component_version_as_semver2(component)}" | ||
| ) | ||
|
|
||
| if remaining_docker_releases: |
There was a problem hiding this comment.
@tiborsimko currently this check causes the following error:
reana-dev release-helm [5:34:17]
[2020-09-02T17:34:17] reana-job-controller: git describe --tags
[2020-09-02T17:34:17] reana-server: git describe --tags
[2020-09-02T17:34:18] reana-workflow-controller: git describe --tags
The following components are missing to be released:
reana-auth-vomsproxy
reana-ui
reana-message-broker
reana-workflow-engine-cwl
reana-workflow-engine-serial
reana-workflow-engine-yadageBecause we do not have tags for previous versions. Should we make this check optional? Or should we create tags for the previous releases?
There was a problem hiding this comment.
Hmm, we do have tag 0.7.0a1 for r-w-e-serial for example?
diegodelemos
force-pushed
the
331-tags-and-versions
branch
from
c934ef7
to
058df25
Compare
reana/reana_dev/release.py
Outdated
| ) | ||
|
|
||
| if publish: | ||
| package_and_publish_helm_chart(user, version, component) |
There was a problem hiding this comment.
This is what I've ended up with, reana-dev release-helm would do too many things.
I think we could split it as:
- Until line
330(updatingvalues.yamland bumping version, similar toreana-dev git-upgrade-shared-modulesbut for Helm and docker images) we could have a new command e.g.reana-dev helm-upgrade-componentsor similar - Then one would run
reana-dev git-create-release-commit - Lastly, the true
reana-dev release-helmwould just consist ofpackage_and_publish_helm_chart
What do you think?
diegodelemos
force-pushed
the
331-tags-and-versions
branch
3 times, most recently
from
2d289ee
to
6e05a78
Compare
|
Tested in local repo, outcome here, steps to reproduce: $ reana-dev helm-upgrade-components
$ reana-dev release-helm -u <YOUR-GITHUB-USERNAME> |
diegodelemos
force-pushed
the
331-tags-and-versions
branch
3 times, most recently
from
7ba29a0
to
9818720
Compare
diegodelemos
force-pushed
the
331-tags-and-versions
branch
from
9818720
to
cbd38f3
Compare
reana/reana_dev/release.py
Outdated
| f"rm -rf {index_path}", | ||
| f"mkdir {index_path}", | ||
| f"helm package helm/reana --destination {package_path} --dependency-update", | ||
| f"cr upload -o {user} -r {component}", |
There was a problem hiding this comment.
Discovered while amending #411 and checking out https://github.com/diegodelemos/reana/releases/tag/reana-0.7.0-alpha.2:
We should pass --release-name-template "{{ .Version }}" so the release on GitHub doesn't contain the reana- prefix (more here).
diegodelemos
force-pushed
the
331-tags-and-versions
branch
from
cbd38f3
to
e4c5ddf
Compare
diegodelemos
force-pushed
the
331-tags-and-versions
branch
from
e4c5ddf
to
78615e6
Compare
reana/reana_dev/helm.py
Outdated
| ) | ||
| from reana.reana_dev.utils import ( | ||
| display_message, | ||
| get_component_version_as_semver2, |
There was a problem hiding this comment.
Needs amending, as get_component_version_as_semver2() does not exist...
There was a problem hiding this comment.
... and need to import get_docker_tag(). Otherwise it seems to work well 👍
diegodelemos
force-pushed
the
331-tags-and-versions
branch
from
78615e6
to
b14aa23
Compare
diegodelemos
force-pushed
the
331-tags-and-versions
branch
from
b14aa23
to
41f96ac
Compare
Pending: