Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add command to generate build status wiki #436

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

mvidalgarcia
Copy link
Member

closes #435

@codecov-io
Copy link

Codecov Report

Merging #436 into master will decrease coverage by 0.46%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
- Coverage   15.61%   15.14%   -0.47%     
==========================================
  Files          15       16       +1     
  Lines        1326     1367      +41     
==========================================
  Hits          207      207              
- Misses       1119     1160      +41     
Impacted Files Coverage Δ
reana/reana_dev/cli.py 0.00% <0.00%> (ø)
reana/reana_dev/wiki.py 0.00% <0.00%> (ø)

Comment on lines 74 to 88
"reana-demo-alice-lego-train-test-run": {},
"reana-demo-alice-pt-analysis": {},
"reana-demo-atlas-recast": {},
"reana-demo-bsm-search": {},
"reana-demo-cdci-crab-pulsar-integral-verification": {},
"reana-demo-cdci-integral-data-reduction": {},
"reana-demo-cms-h4l": {},
"reana-demo-cms-reco": {},
"reana-demo-cms-dimuon-mass-spectrum": {},
"reana-demo-fcchh-fullsim": {},
"reana-demo-helloworld": {},
"reana-demo-lhcb-d2pimumu": {},
"reana-demo-lhcb-mc-production": {},
"reana-demo-root6-roofit": {},
"reana-demo-worldpopulation": {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if for all these lists we use the same config that reana-dev uses in general, e.g. in this case REPO_LIST_DEMO. CC @tiborsimko is there any reason why REPO_LIST_DEMO doesn't contain all demos and part of them are just in REPO_LIST_ALL? Maybe with this PR comes the time to harmonise it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REPO_LIST_DEMO contains only known "runnable examples", i.e. ones that are fast to run locally on a typical developer box. They are used for reana-dev run-ci -c DEMO.

Hence the other examples, that are "non-runnable" locally, are living outside only as part of REPO_LIST_ALL.

If we want we could amend this and introduce REPO_LIST_DEMO_RUNNABLE, REPO_LIST_DEMO_ALL for example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

else:
headers = [
"Package",
"`maint-0.7`",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about extracting maint-0.7 to a variable? e.g. MAINT_BRANCHES = ["maint-0.7"] so when:

  • A new maint branch is created we just add it to the list.
  • When we drop support for a given version, we just remove it from the list.

(affecting code below)


GITHUB_REANAHUB_URL = "https://github.com/reanahub"
CODECOV_REANAHUB_URL = "https://codecov.io/gh/reanahub"
MAINT_BRANCHES = ["maint-0.7"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we have GIT_DEFAULT_BASE_BRANCH in reana/config.py. So this variables could go there and use a similar name, perhaps GIT_SUPPORTED_MAINT_BRANCHES? You could also move the other two there.

"simple": True,
"title": "Examples",
"description": "Selected reusable analysis examples.",
"packages": {demo: {} for demo in REANA_LIST_DEMO_ALL},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we need to .sort() them so that demo repositories are coming up alphabetically? (thinking about that now the variable is a join of two lists)

@diegodelemos diegodelemos merged commit 37e906f into reanahub:master Nov 9, 2020
@mvidalgarcia mvidalgarcia deleted the 435-wiki-ci-links branch November 9, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wiki: update CI build links
4 participants